Pet losing some - not all - his gear

[noudess]

Had the same pet for at least a week. He has 7 pieces of rawhide armor. Every couple of days, the bp and legs disaappear. Anyone know where in the code this stuff gets updated? I look at the table and it has what I expect.. At some point, no idea when, he loses the bp and legs (not in table anymre). Really weird, Maybe an issue when loggin in and loading pet?

[ I see where it gets loaded and saved - that code looks fine. Will instrument it, but don't expect the problem to be there. ]

[Uleat]

Usually, a code problem like that will manifest itself every time.

You might try looking at all of your logs (emu server, mysql, etc...) to see if you are having write issues. A write failure would case items to 'randomly' disappear.


I am working through inventory code atm..so, I'll keep an eye out for anything that might be wonky.

[provocating]

No rent items? Nevermind just read where you said it was rawhide.

[Uleat]

No rent typically disappear after 30 minutes offline..I don't even know if pets check for that.

[provocating]

Originally Posted by Uleat

No rent typically disappear after 30 minutes offline..I don't even know if pets check for that.

I know, I missed that when I read his post.

[noudess]

From further testing, it looks like the database is fine after the items are lost in game. The db only gets messed up after you log out of the client, and the corrupted pet inventory gets written back out. So, the loss of items seems to be on zoning, and in memory.

I'm going to focus on that today and see what I can find.

[noudess]

Gave pet 12 items. Logged out to update db.

Logged back in and then zoned 9 times. On the 9th time only the 1st 5 items survived when I did a #showstats. The exact 1st 5 items, so the list got truncated. I'm guessing a race condition that didn't let the list get filled in, or perhaps somehow that process got interrupted?

This narrows the repeat process to logging in and zoning alot. I was the only one on the server at the time as well.

[Akkadius]

I want to say I experienced this bug myself when I was somewhat actively running Akka's Funhouse.

It is probably an initialization issue when entering the zone.

[noudess]

Looking for some feedback on what I am seeing.

I don't see where we're corrupting yet, but I find this odd.

Instrumentation:

- I have log messages in ~NPC and in the spot where the pet gets his gear restored.

Steps:

- Fresh server restart
- Login with existing pet to zone 1.
- I see the pet gear restore loop run fine.
- #zone to zone 2
- I see the pet gear restore loop run fine.
- #zone to zone 1 again.
- The process for zone1 hits the ~NPC code for the pet
- I see the pet gear restore fine after this.

Isn't it odd that the ~NPC code for the pet runs when I reenter the original zone and not when I leave one?

[noudess]

I think I have found the issue... information as soon as I verify the fix....

[noudess]

Ok....

It looks like the zone you are leaving stores the pets inventory into the DB using a loop of inserts. The zone you are entering retrieves the list with a single select.

Sometimes, depending on how fast you zone and how many items are in the pets inventory list, the receiving zone does the select before the sending zone has finished putting the items in.

I added a LOCK TABLES character_pet_inventory WRITE on the side saving the data, along with a release after the loop of inserts. I then added a LOCK TABLES READ on the destination zone's code to reload the data with the select.

I zoned 25 times and it has not failed with 12 pet items. That's never happened for me before, so I think that got it.

I'll post the code after a week or so of testing.

[noudess]

Patch code below:

***************
*** 2440,2459 ****
--- 2440,2464 ----
  				errbuf);
  			safe_delete_array(query);
  		}
  	}
  
+ 	database.RunQuery(query, MakeAnyLenString(&query, "LOCK TABLES `character_pet_inventory` WRITE", errbuf));
+ 	printf(errbuf);
+ 
  	for(i=0; i<MAX_WORN_INVENTORY; i++) {
  		if(petinfo->Items[i]) {
  			database.RunQuery(query, MakeAnyLenString(&query,
  				"INSERT INTO `character_pet_inventory` (`char_id`, `pet`, `slot`, `item_id`) values (%u, 0, %u, %u)",
  				c->CharacterID(), i, petinfo->Items[i]), errbuf);
  			// should check for errors
  			safe_delete_array(query);
  		}
  	}
  
+ 	database.RunQuery(query, MakeAnyLenString(&query,"UNLOCK TABLES", errbuf));
+ 	printf(errbuf);
  	
  	if(!database.RunQuery(query, MakeAnyLenString(&query,
  		"INSERT INTO `character_pet_info` (`char_id`, `pet`, `petname`, `petpower`, `spell_id`, `hp`, `mana`) "
  		"values (%u, 1, '%s', %u, %u, %u, %u) "
  		"ON DUPLICATE KEY UPDATE `petname`='%s', `petpower`=%i, `spell_id`=%u, `hp`=%u, `mana`=%u",
***************
*** 2581,2590 ****
--- 2586,2598 ----
  		LogFile->write(EQEMuLog::Error, "Error in LoadPetInfo query '%s': %s", query, errbuf);
  		safe_delete_array(query);
          return;
  	}
  
+ 	database.RunQuery(query, MakeAnyLenString(&query, "LOCK TABLES `character_pet_inventory` WRITE", errbuf));
+ 	printf(errbuf);
+ 
  	if (database.RunQuery(query, MakeAnyLenString(&query,
  		"SELECT `pet`, `slot`, `item_id` FROM `character_pet_inventory` WHERE `char_id`=%u",
  		c->CharacterID()), errbuf, &result))
  	{
  		safe_delete_array(query);
***************
*** 2608,2614 ****
--- 2616,2625 ----
  	else {
  		LogFile->write(EQEMuLog::Error, "Error in LoadPetInfo query '%s': %s", query, errbuf);
  		safe_delete_array(query);
          	return;
  	}
+ 	// Unlock the character_pet_inventory table so people can read
+ 	database.RunQuery(query, MakeAnyLenString(&query, "UNLOCK TABLES",errbuf));
+ 	printf(errbuf);
  
  }

[noudess]

Fixed my problem but created other issues for other clients in the same zone....

My unlock is messing with other tables - apparantly no way to unlock just the one table..

Working on a cleaner solution using a mutex.

[noudess]

Ok, this is deeper into the infrastructure than I've messed with.

The idea of locking/unlocking the tables isn't going to work as unlock always releases all tables, and there is other code executing for other clients in the same zone process that locks tables.. So I can't use that method.

A simple mutex is out, as I'm on linux and mutexes don't cross processes without shared memory.

So, I'm guessing a semaphore.. In that case I need to know where all the zone processes are forked, so I can create the semaphore before the zones are forked off.

Or - is there a better way being used already to make sure that 2 zone processes get synbcronized?

[Uleat]

I've seen a few crash dumps involving pets..I wonder if this is related...