Having issues with bots dying and zones crashing

cubber · #1 02-20-2009, 11:22 AM

I have been having this issue since around rev 330 or so. Please see this thread for the full writeup and what I have done to track it down to bots:

http://www.eqemulator.net/forums/showthread.php?t=27523

At first zones were crashing when a PC died and bots died. Also even when bots werent enabled. I changed up my make files a bit and now it only happens when I have bots enabled and a bot dies.

**Congdar** · #2 02-20-2009, 01:16 PM

I am currently testing a fix on my server.

cubber · #3 02-20-2009, 01:37 PM

Is it a confirmed issue then or just isolated to me? More testing shows that it is happening randomly on bots and not at all on players now. I have posted more info in my link.

**Congdar** · #4 02-20-2009, 07:30 PM

It's a tough find. One fix was SVN 350 where the check for flash of steel aa was checking the attacker instead of the defender and the attacker had just died from the first riposte. the attacker was a bot and the reference to the bot object was gone.

I'm seeing some other crashes too that seem to be race conditions where the bot has died and it's object is not yet set to null but all of it's data is garbage.

I do have some legit fixes too but i'm still seeing these other bugs.

cubber · #5 02-20-2009, 08:08 PM

SVN 350 is where the crashes became more random instead of all the time.

Thanks for taking the time to look into this.

**Congdar** · #6 02-21-2009, 05:13 PM

I removed my last major bot update. I'm hoping this either stops the crashing issue or eliminates that update as the cause.

cubber · #7 02-21-2009, 06:07 PM

Seems to be ok now. I can die with a PC character and not crash the zone and I have "fed" Grand Master Glox 6 bots without a zone crash.

Edit: This was on Rev 354 with the required SQL removed as per the changelog.

**Congdar** · #8 02-21-2009, 06:29 PM

I may have been a bit premature on reverting. Angelox seems to have a line on the crash fix. It has something to do with removeMob() vs removeNPC() when the bot dies. removeMob() calls removeNPC() and the zone crashes. Calling removeNPC() instead, the zone doesn't crash but i'm wondering about the mob_list still containing an entry for the bot.

cubber · #9 02-21-2009, 09:03 PM

I just got done playing on rev 354 for about 2 hours with a group of bots. I died a few times, they died a few times. Was all around fun! So it is deffinitly not an issue in this revision.

The new bot management/quest system was very nice, so hopefully you guys are on to something there and it will get worked out.

Anyway thank you from preventing me from pulling all of my hair out thinking the problem was just on my end!

**Congdar** · #10 02-21-2009, 11:53 PM

Try svn355. Hopefully all is well in botworld now.

cubber · #11 02-22-2009, 11:12 AM

I take it in rev 355 we need to re-add the deleted sql for the bot management? It is not in the changelog.

cubber · #12 02-22-2009, 12:53 PM

All seems well in Rev 355

**Congdar** · #13 02-22-2009, 03:22 PM

Quote:

Originally Posted by cubber

I take it in rev 355 we need to re-add the deleted sql for the bot management? It is not in the changelog.

It's in changelog.txt