Delete Zone Version - Nuking grids?

[N0ctrnl]

First of all, I love EoC and I use it a lot for comparing zone versions and moving them around. It's a great tool and I'm happy to have it.

That said, I'm having some issues with the "Delete Zone Version" option. Every time I delete a zone version, I have to go back and put all my pathing grids back in because of the following:

DELETE FROM grid WHERE id='999999999999' 
 OR id='1'
 OR id='2'
 OR id='3'
 OR id='4'
 OR id='5'
 OR id='6'
 OR id='7'
 OR id='8'
 OR id='9'
 OR id='10'
 OR id='11'
 OR id='12'
 OR id='13'
 OR id='13'
 OR id='14'
 OR id='14'
 OR id='15'
 OR id='16'
 OR id='16'
 OR id='16'
 OR id='16'
 OR id='17'
 OR id='18'
 OR id='19'
 OR id='20'
 OR id='21'
 OR id='22'
 OR id='23'
 OR id='24'
 OR id='25'
 OR id='26'
 OR id='27'
 OR id='28'
 OR id='29'
 OR id='30'
 OR id='31'
 OR id='32'
 OR id='32'
 OR id='32'
 OR id='33'
 OR id='33'
 OR id='33'
 OR id='33'
 OR id='33'
 OR id='34'
 OR id='34'
 OR id='35'
 OR id='35'
 OR id='36'
 OR id='37'
 OR id='38'
 OR id='39'
 OR id='40'
 OR id='41'
 OR id='42'
 OR id='43'
 OR id='43'
 OR id='43'
 OR id='44'
 OR id='44'
 OR id='44'
 OR id='45'
 OR id='45'
 OR id='46'
 OR id='46'
 OR id='47'
 OR id='48'
 OR id='49'
 OR id='50'
 OR id='51'
 OR id='52'
 OR id='53'
 OR id='54'
 OR id='55'
 OR id='56'
 OR id='57';
DELETE FROM grid_entries WHERE gridid='999999999999' 
 OR gridid='1'
 OR gridid='2'
 OR gridid='3'
 OR gridid='4'
 OR gridid='5'
 OR gridid='6'
 OR gridid='7'
 OR gridid='8'
 OR gridid='9'
 OR gridid='10'
 OR gridid='11'
 OR gridid='12'
 OR gridid='13'
 OR gridid='13'
 OR gridid='14'
 OR gridid='14'
 OR gridid='15'
 OR gridid='16'
 OR gridid='16'
 OR gridid='16'
 OR gridid='16'
 OR gridid='17'
 OR gridid='18'
 OR gridid='19'
 OR gridid='20'
 OR gridid='21'
 OR gridid='22'
 OR gridid='23'
 OR gridid='24'
 OR gridid='25'
 OR gridid='26'
 OR gridid='27'
 OR gridid='28'
 OR gridid='29'
 OR gridid='30'
 OR gridid='31'
 OR gridid='32'
 OR gridid='32'
 OR gridid='32'
 OR gridid='33'
 OR gridid='33'
 OR gridid='33'
 OR gridid='33'
 OR gridid='33'
 OR gridid='34'
 OR gridid='34'
 OR gridid='35'
 OR gridid='35'
 OR gridid='36'
 OR gridid='37'
 OR gridid='38'
 OR gridid='39'
 OR gridid='40'
 OR gridid='41'
 OR gridid='42'
 OR gridid='43'
 OR gridid='43'
 OR gridid='43'
 OR gridid='44'
 OR gridid='44'
 OR gridid='44'
 OR gridid='45'
 OR gridid='45'
 OR gridid='46'
 OR gridid='46'
 OR gridid='47'
 OR gridid='48'
 OR gridid='49'
 OR gridid='50'
 OR gridid='51'
 OR gridid='52'
 OR gridid='53'
 OR gridid='54'
 OR gridid='55'
 OR gridid='56'
 OR gridid='57';

(This was part of removing a version of The Hole that I imported to a new version from another DB)

I understand the intent - to remove the copied grid information. But this is removing all grids with those IDs, regardless of zone. Shouldn't this have something like a "AND zoneid = 'XX'" added to it so it doesn't remove grids for other zones as well?

[Akkadius]

That certainly doesn't look right. This is just from doing a delete zone version?

[N0ctrnl]

Yeah. This isn't the first time either. I have been puzzled at why my grid and grid_entries have been getting hosed.

[Akkadius]

Alright, I've nuked the code that deletes grid entries and grids as there is no filter on version that is honestly necessary for this.

Even if I joined tables on the NPC's that are imported there is a high possibility that the gridid may potentially conflict so deleting doesn't make all that much sense.

https://github.com/Akkadius/EQEmuEOC...f1d2db0f5a944c

I've pulled on live EoC these changes, so you should be good to go

[N0ctrnl]

Thanks man!