Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Bug Reports

Development::Bug Reports Post detailed bug reports and what you would like to see next in the emu here.

Reply
 
Thread Tools Display Modes
  #1  
Old 09-06-2009, 03:20 PM
EvoZak
Sarnak
 
Join Date: May 2008
Location: Midwest
Posts: 72
Default NPCs adding elemental and bane dmg twice?

Regarding the combat calculations for NPCs, it looks as if the bane and elemental damage is getting accumulated twice... or I'm confused

In checks to GetWeaponDamage(), the returned damage has elem and bane included. There are comments later that for NPCs, bane/elem dmg needs to be added since it wasn't earlier. But it was.

Noticed this and thought someone may appreciate the heads up. Or like I said, I'm just confused, but it looks like that's what is going on.
Reply With Quote
  #2  
Old 09-06-2009, 03:51 PM
ChaosSlayerZ's Avatar
ChaosSlayerZ
Demi-God
 
Join Date: Mar 2009
Location: Umm
Posts: 1,492
Default

Quote:
Originally Posted by EvoZak View Post
Regarding the combat calculations for NPCs, it looks as if the bane and elemental damage is getting accumulated twice... or I'm confused

In checks to GetWeaponDamage(), the returned damage has elem and bane included. There are comments later that for NPCs, bane/elem dmg needs to be added since it wasn't earlier. But it was.

Noticed this and thought someone may appreciate the heads up. Or like I said, I'm just confused, but it looks like that's what is going on.
I have reported this like back in May and I was told it was since long fixed. After R535
Reply With Quote
  #3  
Old 09-06-2009, 05:51 PM
trevius's Avatar
trevius
Developer
 
Join Date: Aug 2006
Location: USA
Posts: 5,946
Default

Yeah, we fixed that quite a while ago. Try to make sure you are running the latest source if you are going to report bugs, please.
__________________
Trevazar/Trevius Owner of: Storm Haven
Everquest Emulator FAQ (Frequently Asked Questions) - Read It!
Reply With Quote
  #4  
Old 09-06-2009, 09:28 PM
EvoZak
Sarnak
 
Join Date: May 2008
Location: Midwest
Posts: 72
Default

I'm updated to latest version out of SVN. However, like always, after posting in a forum and looking at it again I don't think it's a bug. Just sorta opaque code IMO.

The first calc adds the elem & bane dmg for POTENTIAL dmg. Later the min & max damage is augmented with the elem & bane damage for a range of the actual damage done.

So no bug, and no harm done by my uninformed posting. Perhaps someone else that is thinking the same thing will find this.
Reply With Quote
  #5  
Old 09-06-2009, 10:02 PM
trevius's Avatar
trevius
Developer
 
Join Date: Aug 2006
Location: USA
Posts: 5,946
Default

Maybe if you post the code you are referring to, it will be easier to see what you are talking about. I know that KLS and I worked on some issues with Bane and Elemental damage a couple of months ago that was adding Double (and then some) to the calculations. That particular issue has been resolved, but maybe there is still a problem somewhere else?
__________________
Trevazar/Trevius Owner of: Storm Haven
Everquest Emulator FAQ (Frequently Asked Questions) - Read It!
Reply With Quote
  #6  
Old 09-07-2009, 07:02 PM
EvoZak
Sarnak
 
Join Date: May 2008
Location: Midwest
Posts: 72
Default

You misunderstand... there is no bug. And hence, no code posting. I was simply trying to describe what is going on with the calcs and why I thought there might have been a bug.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 07:26 AM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3