SE_CriticalSpellChance Code Fix + Frenzied Devastation (Wiz AA)

[Shin Noir]

I may need to do some more testing before this is 100%, because I did this while I'm sleepy.

Index: spell_effects.cpp
===================================================================
--- spell_effects.cpp	(revision 998)
+++ spell_effects.cpp	(working copy)
@@ -2752,6 +2752,7 @@
 			case SE_LimitMinLevel:
 			case SE_LimitCastTime:
 			case SE_NoCombatSkills:
+			case SE_CriticalSpellChance: //Shin: This is handled in focus effects.
 			{
 				break;
 			}
@@ -3716,6 +3717,10 @@
 					value = focus_spell.base[i];
 			}
 			break;
+		case SE_CriticalSpellChance: //Shin: Crit Chance is merely a % chance of base.
+			if (type == focusImprovedCritical)
+				value = focus_spell.base[i];
+			break;
 #if EQDEBUG >= 6
 		//this spits up a lot of garbage when calculating spell focuses
 		//since they have all kinds of extra effects on them.

Index: spdat.h
===================================================================
--- spdat.h	(revision 998)
+++ spdat.h	(working copy)
@@ -399,7 +399,7 @@
 #define SE_Purify					291 //not implemented
 //#define SE_Unknown292				292	//not used
 //#define SE_Unknown293				293	//not used
-#define SE_CriticalSpellChance		294 //not implemented
+#define SE_CriticalSpellChance		294 //Shin: Added on focus effects during GetActSpellDamage()
 //#define SE_Unknown295				295	//not used
 #define SE_SpellVulnerability		296	//not implemented, base % increase in incoming spell damage
 #define SE_Empathy					297 //some kind of damage focus effect, maybe defensive?

You can test this with Spirit of Vesagran (bard epic click) #cast 6271

Frenzied Devastation it seems on default titanium client is using a placeholder SE of 212 (SE_ProlongedDestruction in source), and it was later changed (lucy link) to utilize the SE of 294 (which I just fixed).

I wrote a little patch (this may need verification) for this AA:

update spells_new set name = "Frenzied Devastation", effect_base_value6 = 7, effectid1 = 132, effect_base_value1 = -100, effect_limit_value1 = 1, effect_base_value2 = 1, effectid2 = 141, effectid3 = 138, effectid4 = 137, effectid5 = 311, effect_base_value5 = 7, effectid6 = 294, effect_limit_value6 = 100, cast_on_you = "You feel frenzied devastation come upon you.", spell_fades = "The frenzied devastation fades.", skill = 98, buffduration = 20, buffdurationformula = 3 where id = 5245 or id = 5246 or id = 5247;
update spells_new set effect_base_value6 = 26 where id = 5246;
update spells_new set effect_base_value6 = 40 where id = 5247;

and this was snagged from latest Everquest's spells_us.txt

5245^Frenzied Devastation^BLUE_TRAIL^^^^You feel frenzied devastation come upon you.^^The frenzied devastation fades.^^^0^0^0^0^0^3^20^0^0^-100^1^0^0^0^7^0^0^0^0^0^0^0^0^0^0^0^100^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^-1^-1^-1^-1^1^1^1^1^-1^-1^-1^-1^100^100^100^100^100^100^100^100^100^100^100^100^0^1^^0^132^141^138^137^311^294^254^254^254^254^254^254^6^0^98^-1^0^0^255^255^255^255^255^255^255^255^255^255^255^254^255^255^255^255^44^13^0^-1^^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^100^0^133^0^0^0^0^0^0^0^0^0^-1^0^^^^0^0^0^0^100^0^0^0^0^0^0^0^0^0^0^0^7^3^0^100^0^^3^20^0^1^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^1^0^0^0^1^0^-1^0^0^0^1^0^0^1^1^1^0^-1^0^0^0^1^25^-1^0^1^0^0^1^0^1^0
5246^Frenzied Devastation^BLUE_TRAIL^^^^You feel frenzied devastation come upon you.^^The frenzied devastation fades.^^^0^0^0^0^0^3^20^0^0^-100^1^0^0^0^26^0^0^0^0^0^0^0^0^0^0^0^100^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^-1^-1^-1^-1^1^1^1^1^-1^-1^-1^-1^100^100^100^100^100^100^100^100^100^100^100^100^0^1^^0^132^141^138^137^311^294^254^254^254^254^254^254^6^0^98^-1^0^0^255^255^255^255^255^255^255^255^255^255^255^254^255^255^255^255^44^13^0^-1^^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^100^0^133^0^0^0^0^0^0^0^0^0^-1^0^^^^0^0^0^0^100^0^0^0^0^0^0^0^0^0^0^0^7^6^0^100^0^^3^20^0^1^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^1^0^0^0^1^0^-1^0^0^0^1^0^0^1^1^1^0^-1^0^0^0^1^25^-1^0^1^0^0^1^0^1^0
5247^Frenzied Devastation^BLUE_TRAIL^^^^You feel frenzied devastation come upon you.^^The frenzied devastation fades.^^^0^0^0^0^0^3^20^0^0^-100^1^0^0^0^40^0^0^0^0^0^0^0^0^0^0^0^100^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^-1^-1^-1^-1^1^1^1^1^-1^-1^-1^-1^100^100^100^100^100^100^100^100^100^100^100^100^0^1^^0^132^141^138^137^311^294^254^254^254^254^254^254^6^0^98^-1^0^0^255^255^255^255^255^255^255^255^255^255^255^254^255^255^255^255^44^13^0^-1^^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^100^0^133^0^0^0^0^0^0^0^0^0^-1^0^^^^0^0^0^0^100^0^0^0^0^0^0^0^0^0^0^0^7^9^0^100^0^^3^20^0^1^0^0^0^0^0^0^0^0^0^0^0^0^0^0^0^1^0^0^0^1^0^-1^0^0^0^1^0^0^1^1^1^0^-1^0^0^0^1^25^-1^0^1^0^0^1^0^1^0

Seems to be Titanium compatible? Note that during a previous revision, the mana cost made a value -100 to say "double mana cost", but I think latest EQ removed this? I didn't test this portion but just wanted to note about it.