agility <=300 bug

[John Adams]

This may not really be a bug, but it is spamming the emu's error log with Client::acmod() errors. I notice players with an agility of 305 never get checked, and the code ends at logging an error.

client_mods.cpp

Error in Client::acmod(): Agility: 310, Level: 70

I have not tried this fix myself yet, but the last check in client_mods.cpp (line 55 is:

	} else if(agility <= 300) {

There doesn't appear to be a catch-all for anything above 300. Is it safe to change that to a catch-all for anything > 300 and be done with it? I will try it locally and report back.

	} else if(agility > 300) {

What I don't know is, what would the ac modifiers be for an agility > 300, if any?

[gernblan]

I just always comment out that logfile write before I compile in client_mods.cpp I think it is (I do it so automatically now I don't even remember the name of the file I just do it heh).

I"m sure it's valuable information to someone. Just not me hehe

[BWStripes]

I'd already reported that in this thread:

http://www.eqemulator.net/forums/showthread.php?t=23067

Basically if you're L70 maxed AGI with all AAs, your AGI would be 355. Just change the figure as I indicated and it stops.

[John Adams]

Yes, I was sure it was mentioned before. I was specifically asking if there were acmod() that should be considered for those > 300 - or, is everything modified exactly the same from 300-400? (I think 390 is the highest I've seen so far).

It is easy to dupe the code block to handle the different levels. Just not sure of the acmod() that should be addressed > 300 AGI.

[gernblan]

Great question. I would imagine the answer is yes, but to what degree?