Level 10/20 damage caps

Tabasco · #1 07-11-2012, 08:28 PM

In zone/attack.cpp
This:

Code:

if(GetLevel() < 10 && max_hit > 20)
    max_hit = (RuleI(Combat, HitCapPre10));
else if(GetLevel() < 20 && max_hit > 40)
    max_hit = (RuleI(Combat, HitCapPre20));

Should probably be this:

Code:

if(GetLevel() < 10 && max_hit > RuleI(Combat, HitCapPre10))
{
    max_hit = (RuleI(Combat, HitCapPre10));
}
else if(GetLevel() < 20 && max_hit > RuleI(Combat, HitCapPre20))
{
    max_hit = (RuleI(Combat, HitCapPre20));
}

It's not going to be an issue for most people, but it could cause some problems on custom servers.

lerxst2112 · #2 07-12-2012, 02:50 AM

Bot::Attack also has some issues with that, assuming that bots should use the same caps as players.

Code:

		if(GetLevel() < 10 && max_hit > 20)
			max_hit = 20;
		else if(GetLevel() < 20 && max_hit > 40)
			max_hit = 40;