Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Development

Development::Development Forum for development topics and for those interested in EQEMu development. (Not a support forum)

Reply
 
Thread Tools Display Modes
  #1  
Old 09-28-2014, 04:11 PM
noudess
Discordant
 
Join Date: Sep 2012
Location: Upstate NY
Posts: 274
Default git coaching

So I did a fork, pulled down a local copy, made changes, committed locally and then did a push to my fork.

Then, I did a pull request. That request is still open.

Question. I just fixed a completely separate bug and commited that locally. If I do a push to my fork, will that pollute my existing pull request? If not, can I create a second pull request for just the new change?

I'm totally new to git.

Thx.
Reply With Quote
  #2  
Old 09-28-2014, 04:20 PM
Kingly_Krab
Administrator
 
Join Date: May 2013
Location: United States
Posts: 1,594
Default

If you push and overwrite, the new changes should be in the same pull request.
Reply With Quote
  #3  
Old 09-28-2014, 04:28 PM
noudess
Discordant
 
Join Date: Sep 2012
Location: Upstate NY
Posts: 274
Default

That's the issue. I don't think you guys want changes that are unrelated to each other in a pull. I could be wrong. My current pull request is for 1 issue. I figure you guys don't need to see stuff nixed together.

I didnt want to push the bug fix and have it land in the other pull request.
Reply With Quote
  #4  
Old 09-29-2014, 04:03 AM
KLS
Administrator
 
Join Date: Sep 2006
Posts: 1,348
Default

Was waiting on merging it cause demon had raised some concerns but in the meantime branching is your friend

Creating a branch with name "some_feature_branch_name"
Code:
git checkout -b some_feature_branch_name
To move back to master
Code:
git checkout master
To switch back to branch and merge changes from master you just got
Code:
git checkout some_feature_branch_name
To say merge code from master after you've updated it
Code:
git merge master
You can setup pull requests to use your own named branches instead of master.

Also: http://git-scm.com/book/en/Git-Branc...ng-and-Merging
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 09:56 AM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3