Pets and bane

[demonstar55]

Pets and Swarm pets should be able to hit IMMUNE_MELEE_EXCEPT_BANE mobs

proof: http://everquest.allakhazam.com/db/n...56360625423557

@@ -796,7 +797,8 @@
                }
        }

-       if(against->SpecAttacks[IMMUNE_MELEE_EXCEPT_BANE]){
+       // Pets should be able to hit bane only mobs
+       if(against->SpecAttacks[IMMUNE_MELEE_EXCEPT_BANE] && !GetOwner()){
                if(weapon_item){
                        if(weapon_item->BaneDmgBody == against->GetBodyType()){
                                banedmg += weapon_item->BaneDmgAmt;

[ChaosSlayerZ]

wasn't there a Rule in DB that switched that on and off?
I am pretty sure it was implemented years ago.

[demonstar55]

common % grep -i Pet ruletypes.h
RULE_BOOL( Character, FeignKillsPet, false)
RULE_CATEGORY( Pets )
RULE_REAL( Pets, AttackCommandRange, 150 )
RULE_BOOL (World, IsGMPetitionWindowEnabled, false)
RULE_INT ( Combat, PetAttackMagicLevel, 30)
RULE_BOOL (NPC, UseItemBonusesForNonPets, true)
RULE_BOOL ( NPC, LiveLikeEnrage, false) // If set to true then only player controlled pets will enrage
RULE_INT ( Aggro, PetSpellAggroMod, 10 )

Not that I can tell :/

[Caryatis2]

Rules dont do anything if they arent implemented in the code, so if thats the correct code its irrelevant.

[demonstar55]

Originally Posted by Caryatis2

Rules dont do anything if they arent implemented in the code, so if thats the correct code its irrelevant.

There are multiple places that Bane is checked, I don't remember seeing anything about a rule for Pet v. Bane. Either way, if there is a rule that I missed, it should probably be set to default since the live like behavior is that pets can hit bane w/o bane weapons.

[ChaosSlayerZ]

here you go:

from May 2009 changelog file
KLS: Added Special Attack hit magical 'm' and special attack hit bane 'b', will allow the mobs affected to hit things that require magical or bane weapons to hit



All you need to do is give all pets "b" flag and they will hit bane
at least it should work this way

[demonstar55]

Originally Posted by ChaosSlayerZ

here you go:

from May 2009 changelog file
KLS: Added Special Attack hit magical 'm' and special attack hit bane 'b', will allow the mobs affected to hit things that require magical or bane weapons to hit



All you need to do is give all pets "b" flag and they will hit bane
at least it should work this way

Well then, I guess we can ignore this then :P