[trevius]

To get the skill value of the item being used in the primary spot, I am trying to write a function to handle it. I am not sure if this will work as it is, but might be worth a shot. Basically, it is supposed to get the item ID from the primary slot, and then determine the item type of that item. Finally, it checks the skill value of the player for the skill that item type uses.

I guess this could go in mob.cpp:

int Mob::GetPrimarySkillValue(SkillType &PrimarySkill, const ItemInst* Item_ID)
{
	int16 Item_ID = CastToClient()->GetItemIDAt(13);

	if (Item_ID = NULL)
		PrimarySkill = HAND_TO_HAND;

	else {
		const Item_Struct* item = Item_ID->GetItem();

		switch (item->ItemType)
		{
			case ItemType1HS: // 1H Slashing
			{
				PrimarySkill = _1H_SLASHING;
				break;
			}
			case ItemType2HS: // 2H Slashing
			{
				PrimarySkill = _2H_SLASHING;
				break;
			}
			case ItemTypePierce: // Piercing
			{
				PrimarySkill = PIERCING;
				break;
			}
			case ItemType1HB: // 1H Blunt
			{
				PrimarySkill = _1H_BLUNT;
				break;
			}
			case ItemType2HB: // 2H Blunt
			{
				PrimarySkill = _2H_BLUNT;
				break;
			}
			case ItemType2HPierce: // 2H Piercing
			{
				PrimarySkill = PIERCING;
				break;
			}
			case ItemTypeHand2Hand:
			{
				PrimarySkill = HAND_TO_HAND;
				break;
			}
			default:
			{
				PrimarySkill = NULL;
				break;
			}
		}
	}

	uint16 skill = GetSkill(PrimarySkill);

	return skill;
}

If anyone has any corrections or suggestions on how to do it better, I would be very happy to hear it. I am fairly certain that this will fail to even compile lol.

Once that function is working, all I will need to figure in is the attack rating cap formula, which should be fairly simple. And the new code for #showstats with this function would look like this:

void Mob::ShowStats(Client* client) {
	float attackRating = 0;

	if(this->IsClient()) {
		attackRating = (((GetATK() + GetSkill(OFFENSE)) * 1.342) + ((GetSTR() - 66) * .9) + (GetPrimarySkillValue() * 2.69));
		int32	AR_Cap = 0;  //Attack Rating Cap
		AR_Cap = (GetSkill(OFFENSE) + GetPrimarySkillValue() ) * 5;  //This isn't correct, but putting it here until I have the correct formula for caps
		if (attackRating > AR_Cap)
			attackRating = AR_Cap;

		if (attackRating < 10)
			attackRating = 10;
	}
	else
	attackRating = GetATK() + (GetSTR() * 9 / 10);

	client->Message(0, "Name: %s %s", GetName(), lastname);
	client->Message(0, "  Level: %i  MaxHP: %i  CurHP: %i  AC: %i  Class: %i", GetLevel(), GetMaxHP(), GetHP(), GetAC(), GetClass());
	client->Message(0, "  MaxMana: %i  CurMana: %i  ATK: %i  Size: %1.1f", GetMaxMana(), GetMana(), attackRating, GetSize());

If I get this attack rating calculation working smoothly, I may try to just make a function to handle the whole thing, so we could just use GetTotalATK() where needed instead of doing the same code over and over.

That code would be something like this:
EDIT: Change the code below for GetTotalATK() a bit.
client.cpp

uint16 Client::GetTotalATK()
{
	int16 AttackRating = 0;

	if(IsClient()) {
		AttackRating = (((GetATK() + GetSkill(OFFENSE)) * 1.342) + ((GetSTR() - 66) * 0.9) + (GetPrimarySkillValue() * 2.69));
		int16	AR_Cap = 0;  //Attack Rating Cap
		AR_Cap = (GetSkill(OFFENSE) + GetPrimarySkillValue()) * 10;  //This isn't correct, but putting it here until I have the correct formula for caps
		if (AttackRating > AR_Cap)
			attackRating = AR_Cap;

		if (AttackRating < 10)
			attackRating = 10;
	}
	else
	AttackRating = GetATK() + (GetSTR() * 9 / 10);

	return AttackRating;
}

Then, the #showstats would just need to have GetATK() replaced with GetTotalATK(), and it should show more accurate values. For the actual attack code to use this, it could just replace the current Attack Rating calculations in mitigation, and just do (GetTotalATK() / 2) instead to get it back to about the same as it is now. NPC DPS wouldn't be effected by this, just players. And by dividing it by 2, it should get them back to about the same as they are now.

Of course, again, if anyone has any corrections or suggestions on how to code this stuff properly, I would be glad to hear them. My coding skills are still really bad and there are certain things I don't understand well or at all yet. I mostly just work by examples I find elsewhere in the source.