Attack Rating Calculations

[trevius]

To get the skill value of the item being used in the primary spot, I am trying to write a function to handle it. I am not sure if this will work as it is, but might be worth a shot. Basically, it is supposed to get the item ID from the primary slot, and then determine the item type of that item. Finally, it checks the skill value of the player for the skill that item type uses.

I guess this could go in mob.cpp:

int Mob::GetPrimarySkillValue(SkillType &PrimarySkill, const ItemInst* Item_ID)
{
	int16 Item_ID = CastToClient()->GetItemIDAt(13);

	if (Item_ID = NULL)
		PrimarySkill = HAND_TO_HAND;

	else {
		const Item_Struct* item = Item_ID->GetItem();

		switch (item->ItemType)
		{
			case ItemType1HS: // 1H Slashing
			{
				PrimarySkill = _1H_SLASHING;
				break;
			}
			case ItemType2HS: // 2H Slashing
			{
				PrimarySkill = _2H_SLASHING;
				break;
			}
			case ItemTypePierce: // Piercing
			{
				PrimarySkill = PIERCING;
				break;
			}
			case ItemType1HB: // 1H Blunt
			{
				PrimarySkill = _1H_BLUNT;
				break;
			}
			case ItemType2HB: // 2H Blunt
			{
				PrimarySkill = _2H_BLUNT;
				break;
			}
			case ItemType2HPierce: // 2H Piercing
			{
				PrimarySkill = PIERCING;
				break;
			}
			case ItemTypeHand2Hand:
			{
				PrimarySkill = HAND_TO_HAND;
				break;
			}
			default:
			{
				PrimarySkill = NULL;
				break;
			}
		}
	}

	uint16 skill = GetSkill(PrimarySkill);

	return skill;
}

If anyone has any corrections or suggestions on how to do it better, I would be very happy to hear it. I am fairly certain that this will fail to even compile lol.

Once that function is working, all I will need to figure in is the attack rating cap formula, which should be fairly simple. And the new code for #showstats with this function would look like this:

void Mob::ShowStats(Client* client) {
	float attackRating = 0;

	if(this->IsClient()) {
		attackRating = (((GetATK() + GetSkill(OFFENSE)) * 1.342) + ((GetSTR() - 66) * .9) + (GetPrimarySkillValue() * 2.69));
		int32	AR_Cap = 0;  //Attack Rating Cap
		AR_Cap = (GetSkill(OFFENSE) + GetPrimarySkillValue() ) * 5;  //This isn't correct, but putting it here until I have the correct formula for caps
		if (attackRating > AR_Cap)
			attackRating = AR_Cap;

		if (attackRating < 10)
			attackRating = 10;
	}
	else
	attackRating = GetATK() + (GetSTR() * 9 / 10);

	client->Message(0, "Name: %s %s", GetName(), lastname);
	client->Message(0, "  Level: %i  MaxHP: %i  CurHP: %i  AC: %i  Class: %i", GetLevel(), GetMaxHP(), GetHP(), GetAC(), GetClass());
	client->Message(0, "  MaxMana: %i  CurMana: %i  ATK: %i  Size: %1.1f", GetMaxMana(), GetMana(), attackRating, GetSize());

If I get this attack rating calculation working smoothly, I may try to just make a function to handle the whole thing, so we could just use GetTotalATK() where needed instead of doing the same code over and over.

That code would be something like this:
EDIT: Change the code below for GetTotalATK() a bit.
client.cpp

uint16 Client::GetTotalATK()
{
	int16 AttackRating = 0;

	if(IsClient()) {
		AttackRating = (((GetATK() + GetSkill(OFFENSE)) * 1.342) + ((GetSTR() - 66) * 0.9) + (GetPrimarySkillValue() * 2.69));
		int16	AR_Cap = 0;  //Attack Rating Cap
		AR_Cap = (GetSkill(OFFENSE) + GetPrimarySkillValue()) * 10;  //This isn't correct, but putting it here until I have the correct formula for caps
		if (AttackRating > AR_Cap)
			attackRating = AR_Cap;

		if (AttackRating < 10)
			attackRating = 10;
	}
	else
	AttackRating = GetATK() + (GetSTR() * 9 / 10);

	return AttackRating;
}

Then, the #showstats would just need to have GetATK() replaced with GetTotalATK(), and it should show more accurate values. For the actual attack code to use this, it could just replace the current Attack Rating calculations in mitigation, and just do (GetTotalATK() / 2) instead to get it back to about the same as it is now. NPC DPS wouldn't be effected by this, just players. And by dividing it by 2, it should get them back to about the same as they are now.

Of course, again, if anyone has any corrections or suggestions on how to code this stuff properly, I would be glad to hear them. My coding skills are still really bad and there are certain things I don't understand well or at all yet. I mostly just work by examples I find elsewhere in the source.

[AndMetal]

Originally Posted by trevius

mob.cpp:

int Mob::GetPrimarySkillValue(SkillType &PrimarySkill, const ItemInst* Item_ID)
{
	int16 Item_ID = CastToClient()->GetItemIDAt(13);

	if (Item_ID = NULL)
		PrimarySkill = HAND_TO_HAND;

	else {
		const Item_Struct* item = Item_ID->GetItem();

		switch (item->ItemType)
		{
			case ItemType1HS: // 1H Slashing
			{
				PrimarySkill = _1H_SLASHING;
				break;
			}
			case ItemType2HS: // 2H Slashing
			{
				PrimarySkill = _2H_SLASHING;
				break;
			}
			case ItemTypePierce: // Piercing
			{
				PrimarySkill = PIERCING;
				break;
			}
			case ItemType1HB: // 1H Blunt
			{
				PrimarySkill = _1H_BLUNT;
				break;
			}
			case ItemType2HB: // 2H Blunt
			{
				PrimarySkill = _2H_BLUNT;
				break;
			}
			case ItemType2HPierce: // 2H Piercing
			{
				PrimarySkill = PIERCING;
				break;
			}
			case ItemTypeHand2Hand:
			{
				PrimarySkill = HAND_TO_HAND;
				break;
			}
			default:
			{
				PrimarySkill = NULL;
				break;
			}
		}
	}

	uint16 skill = GetSkill(PrimarySkill);

	return skill;
}

Per trev and my collaboration, corrections to the first function:

client.cpp:

uint16 Client::GetPrimarySkillValue()
{
	uint8 type = m_inv.GetItem(13)->GetItem()->ItemType;	//is this the best way to do this?
	SkillType skill = HIGHEST_SKILL + 1;	//because NULL == 0, which is 1H Slashing, & we want it to return 0 from GetSkill

	if (!type)
		skill = HAND_TO_HAND;

	else {

		switch (type)
		{
			case ItemType1HS: // 1H Slashing
			{
				skill = _1H_SLASHING;
				break;
			}
			case ItemType2HS: // 2H Slashing
			{
				skill = _2H_SLASHING;
				break;
			}
			case ItemTypePierce: // Piercing
			{
				skill = PIERCING;
				break;
			}
			case ItemType1HB: // 1H Blunt
			{
				skill = _1H_BLUNT;
				break;
			}
			case ItemType2HB: // 2H Blunt
			{
				skill = _2H_BLUNT;
				break;
			}
			case ItemType2HPierce: // 2H Piercing
			{
				skill = PIERCING;
				break;
			}
			case ItemTypeHand2Hand:
			{
				skill = HAND_TO_HAND;
				break;
			}
		}
	}

	return GetSkill(skill);
}

One thing to note is that we'll probably want to put this in the Mob class, then create a virtual function in the NPC class to always return 0, since as far as we know, NPCs don't have "skillz", plus a virtual function (above) for the Client class.

[KLS]

NPCs have skills.

[trevius]

I think we can leave NPC Attack Rating as it is. There isn't really any reason at all I can think of to do any more work for calculating NPC Attack Rating. The only effect it would have would be changing the current DPS that they do. And, since everything is balanced in the current system all it would do would be to make everything have to be rebalanced.

But I do think we can consider changing player attack rating calculations for mitigation and such. If we use a divider after, it should get them mostly back in line with what they are now. But it will be a bit more accurate and will also account for weapon skill, which should be a huge factor in attack rating.

I will try to get the cap formulas figured out later tonight if I have time. I will also verify if there is any difference in the formula from class to class, as I have heard some classes have different worn/spell attack multipliers. Once I know the full formula, I might try to make a GetTotalATK() object that can be used where ever we want without bloating code.

Thanks again, AndMetal, for the help last night. I will give it a try tonight after I get my new VMWare test server running

[trevius]

The code below has been tested and works. But, there is one huge bug that still needs to be corrected before this can be added to the SVN. Currently, it works perfectly, accept if you have an empty primary slot. If the primary slot is empty and you run this command, it crashes the zone.

I will work on resolving the zone crash issue. If anyone has a suggestion, I would be willing to try it. Once I have a good solution, I will edit the code in this post to be the good code.

Also, note that I currently have 3 versions of attack showing on the command output. We can probably leave Worn Attack and Total Attack in there, but in the final version, we probably don't need the server seen attack rating. That is mostly just there for my testing purposes.

I still need to figure out the formula for attack rating caps, but I don't think that will be too hard. Once that is all done, I think this new formula should be pretty complete and fairly accurate.

EDIT: This code is now complete, tested and very accurate. All issues, including the crash and worn caps have been resolved. This has been added to the SVN in Revision. The only minor tweak left to correct is for +attack from spells that can exceed cap, such as Avatar/Champion.

mob.cpp

void Mob::ShowStats(Client* client) {

	int16 attackRating = 0;
	int16 WornCap = GetATK();

	if(IsClient())
		attackRating = GetATK() + ((GetSTR() + GetSkill(OFFENSE)) * 9 / 10);
	else
		attackRating = GetATK() + (GetSTR() * 9 / 10);

	if(WornCap > 250)
		WornCap = 250;

	client->Message(0, "Name: %s %s", GetName(), lastname);
	client->Message(0, "  Level: %i  MaxHP: %i  CurHP: %i  AC: %i  Class: %i", GetLevel(), GetMaxHP(), GetHP(), GetAC(), GetClass());
	client->Message(0, "  MaxMana: %i  CurMana: %i  Size: %1.1f", GetMaxMana(), GetMana(), GetSize());
	client->Message(0, "  Total ATK: %i  Worn ATK: %i  Worn ATK Capped: %i  Server Used ATK: %i", this->CastToClient()->GetTotalATK(), GetATK(), WornCap, attackRating);
	client->Message(0, "  STR: %i  STA: %i  DEX: %i  AGI: %i  INT: %i  WIS: %i  CHA: %i", GetSTR(), GetSTA(), GetDEX(), GetAGI(), GetINT(), GetWIS(), GetCHA());
	client->Message(0, "  MR: %i  PR: %i  FR: %i  CR: %i  DR: %i", GetMR(), GetPR(), GetFR(), GetCR(), GetDR());
	client->Message(0, "  Race: %i  BaseRace: %i  Texture: %i  HelmTexture: %i  Gender: %i  BaseGender: %i", GetRace(), GetBaseRace(), GetTexture(), GetHelmTexture(), GetGender(), GetBaseGender());
	client->Message(0, "  Last Warp Distance: %f Threshold Remaining: %f", GetLWDistance(), GetWarpThreshold());
	if (client->Admin() >= 100) {
		client->Message(0, "  EntityID: %i  PetID: %i  OwnerID: %i  AIControlled: %i", this->GetID(), this->GetPetID(), this->GetOwnerID(), this->IsAIControlled());
		if (this->IsClient()) {
			client->Message(0, "  CharID: %i  PetID: %i", this->CastToClient()->CharacterID(), this->GetPetID());
			client->Message(0, "  Endurance: %i, Max Endurance %i",client->GetEndurance(), client->GetMaxEndurance());
		}
		else if (this->IsCorpse()) {
			if (this->IsPlayerCorpse()) {
				client->Message(0, "  CharID: %i  PlayerCorpse: %i", this->CastToCorpse()->GetCharID(), this->CastToCorpse()->GetDBID());
			}
			else {
				client->Message(0, "  NPCCorpse", this->GetID());
			}
		}
		else if (this->IsNPC()) {
			int32 spawngroupid = 0;
			if(this->CastToNPC()->respawn2 != 0)
				spawngroupid = this->CastToNPC()->respawn2->SpawnGroupID();
			client->Message(0, "  NPCID: %u  SpawnGroupID: %u LootTable: %u  FactionID: %i  SpellsID: %u MerchantID: %i", this->GetNPCTypeID(),spawngroupid, this->CastToNPC()->GetLoottableID(), this->CastToNPC()->GetNPCFactionID(), this->CastToNPC()->GetNPCSpellsID(),this->CastToNPC()->MerchantType);
			client->Message(0, "  Accuracy: %i", CastToNPC()->GetAccuracyRating());
		}
		if (this->IsAIControlled()) {
			client->Message(0, "  AIControlled: AggroRange: %1.0f  AssistRange: %1.0f", this->GetAggroRange(), this->GetAssistRange());
		}
	}
}

client.cpp

uint16 Client::GetPrimarySkillValue()
{
	SkillType skill = HIGHEST_SKILL;  //because NULL == 0, which is 1H Slashing, & we want it to return 0 from GetSkill
	bool equiped = m_inv.GetItem(13);
	
	if (!equiped)
		skill = HAND_TO_HAND;

	else {

		uint8 type = m_inv.GetItem(13)->GetItem()->ItemType;  //is this the best way to do this?

		switch (type)
		{
			case ItemType1HS: // 1H Slashing
			{
				skill = _1H_SLASHING;
				break;
			}
			case ItemType2HS: // 2H Slashing
			{
				skill = _2H_SLASHING;
				break;
			}
			case ItemTypePierce: // Piercing
			{
				skill = PIERCING;
				break;
			}
			case ItemType1HB: // 1H Blunt
			{
				skill = _1H_BLUNT;
				break;
			}
			case ItemType2HB: // 2H Blunt
			{
				skill = _2H_BLUNT;
				break;
			}
			case ItemType2HPierce: // 2H Piercing
			{
				skill = PIERCING;
				break;
			}
			case ItemTypeHand2Hand: // Hand to Hand
			{
				skill = HAND_TO_HAND;
				break;
			}
			default: // All other types default to Hand to Hand
			{
				skill = HAND_TO_HAND;
				break;
			}
		}
	}

	return GetSkill(skill);
}

uint16 Client::GetTotalATK()
{
	int16 AttackRating = 0;
	int16 WornCap = GetATK();

	if(WornCap > 250)
		WornCap = 250;

	if(IsClient()) {
		AttackRating = ((WornCap * 1.342) + (GetSkill(OFFENSE) * 1.345) + ((GetSTR() - 66) * 0.9) + (GetPrimarySkillValue() * 2.69));

		if (AttackRating < 10)
			AttackRating = 10;
	}
	else
	AttackRating = GetATK() + (GetSTR() * 9 / 10);

	return AttackRating;
}

client.h - Anywhere in the file

	//This calculates total Attack Rating to match very close to what the client should show
	uint16 GetTotalATK();
	//This gets the skill value of the item type equiped in the Primary Slot
	uint16 GetPrimarySkillValue();

[trevius]

This code is now complete and is very accurate within about 1 point or so. All issues have been resolved. The only standing addition that needs to be made to be 100% finalized is for spell +attack that is supposed to exceed the worn cap. If there is a way to find the spell attack from spells like Avatar/Champion, it should be very easy to get it added to this code. I added this to the SVN as-is. Currently, it is only used for #showstats, but it could easily be expanded to be used for mitigation calculation. Feedback welcome

[paaco]

Nice Trev, compiling newest Rev now to check it out. Props to you and Andmetal for all the work and testing that went into this.