Helmets

[KLS]

Revision 1035 fixed helm and npc head textures on titanium.

[moydock]

Thanks guys that fixed it. And thanks for all the awesome work you've been doing KLS!

[sfisque]

Originally Posted by KLS

Revision 1035 fixed helm and npc head textures on titanium.

any chance of listing which files diff'ed to fix the helms, for those of us using older builds with custom code (e.g. to manually patch rather than wholesale upgrade).

== sfisque

[oldlurker]

The Sourceforge CVs has the "Diff to previous" feature. that could help you locate the necessary changes.

Or you could diff the 1034 and 1035 source release.

Or you might try to diff your custom code against the code release you started from(and thus creating a patch) and see if it applies to an more recent release.

[sfisque]

Originally Posted by oldlurker

The Sourceforge CVs has the "Diff to previous" feature. that could help you locate the necessary changes.

Or you could diff the 1034 and 1035 source release.

Or you might try to diff your custom code against the code release you started from(and thus creating a patch) and see if it applies to an more recent release.

i was considering #2, but it would then require some work to isolate just the helm fix, as well as anything that had been mod'ed between 992 and current that i didnt want to incorporate.

#3 would be a nightmare because i'm running 992 with some fixes between 992 and 1020-ish manually patched in, and some custom code for my server.

i did a recursive diff one time (against 1032 iirc) and the resulting patch file was hairy to look at.

== sfisque

[KLS]

Index: common/patches/Titanium.cpp
===================================================================
--- common/patches/Titanium.cpp	(revision 1034)
+++ common/patches/Titanium.cpp	(working copy)
@@ -464,7 +464,7 @@
 //		eq->padding0070 = emu->padding0070;
 		eq->eyecolor1 = emu->eyecolor1;
 //		eq->unknown0115[24] = emu->unknown0115[24];
-		eq->showhelm = emu->showhelm;
+		eq->showhelm = true;
 //		eq->unknown0140[4] = emu->unknown0140[4];
 		eq->is_npc = emu->is_npc;
 		eq->hairstyle = emu->hairstyle;
@@ -484,6 +484,7 @@
 		for(k = 0; k < 8; k++) {
 			eq->set_to_0xFF[k] = 0xFF;
 		}
+
 		eq->runspeed = emu->runspeed;
 		eq->afk = emu->afk;
 		eq->guildID = emu->guildID;

Index: common/patches/Titanium_structs.h
===================================================================
--- common/patches/Titanium_structs.h	(revision 1034)
+++ common/patches/Titanium_structs.h	(working copy)
@@ -240,8 +240,8 @@
 /*0238*/ uint32 guildID;        // Current guild
 /*0242*/ char     title[32];      // Title
 /*0274*/ uint8 unknown0274;
-/*0275*/ uint8  set_to_0xFF[8]; // ***Placeholder (all ff)
-/*0283*/ uint8  helm;           // Helm texture
+/*0275*/ uint8  helm;           // Helm texture
+/*0276*/ uint8  set_to_0xFF[8]; // ***Placeholder (all ff)
 /*0284*/ uint32 race;           // Spawn race
 /*0288*/ uint32 unknown0288;
 /*0292*/ char     lastName[32];   // Player's Lastname

[sfisque]

woot, u rule man, thanks kindly!!!

== sfisque

[moydock]

Noticed today that helms disappear when you zone. You can just take them off and put them back on and they show up, but just FYI. Thanks.