I have found one problem with I think is this piece of code. It looks like it has created a new zone crash. I've never seen it before, and since the only thing that has changed in tradeskills is this, I'm opt to think this is the culprit. It's not a common crash by any means (it has happened a total of 3 times on PEQ, which in the grand scheme of things, considering the amount of players and how often they combine isn't a lot) but it's a crash nonetheless. Here's the debug output:
Code:
#0 0x081a6946 in ZoneDatabase::GetTradeRecipe(ItemInst const*, unsigned char, unsigned, DBTradeskillRecipe_Struct*) (this=0x82c5f20, container=0x83e7c28,
c_type=16 '\020', some_id=0, spec=0x0) at Item.h:295
#1 0x081a457d in Object::HandleCombine(Client*, NewCombine_Struct const*, Object*) (user=0x8864fb0, in_combine=0x87fc9f8, worldo=0x83e7b20)
at tradeskills.cpp:140
#2 0x08189351 in Client::Handle_OP_TradeSkillCombine(EQApplicationPacket const*) (this=0x1, app=0x0) at client_packet.cpp:4225
#3 0x0817d410 in Client::HandlePacket(EQApplicationPacket const*) (
this=0x8864fb0, app=0x8818b40) at client_packet.cpp:392
#4 0x080d59f5 in Client::Process() (this=0x8864fb0) at client_process.cpp:581
#5 0x080bb3b3 in EntityList::MobProcess() (this=0x829c220) at entity.cpp:442
#6 0x080e0239 in main (argc=0, argv=0xbfffe514) at net.cpp:479
Just to eliminate the possibility I didn't merge it correctly, could you post a diff? However, I did try out both of the recipes you mentioned, and both combined correctly, and I have heard of no other issues with recipes. So, from a functionality standpoint it certainly is working. I also won't rule out a db error, but I have no idea of how to trace them back.
Threaded Mode
