Fix for merchant price bugs

[ChaosSlayer]

i was under impression, that 'salerate' was some sort of an option to set a custom sell back for each specific item - could realy be usefull in order to create items which would sell back for 100% base price (i can think for dozen fo reason for having such items) - or at least its the only logical explation that coudl posibly fit the description of the field name.

of course the thing never worked, so... =)

but it would be nice to have it actualy working this way =)
(could also be interesting to have item which would sell back for ABOVE base price - again for various reasons) =)

[cavedude]

Moving to submission. To make it easier on KLS/Scorp, could you diff your changes?

[greggg230]

Originally Posted by cavedude

Moving to submission. To make it easier on KLS/Scorp, could you diff your changes?

Sure.

Line 3717 of zone/client_packet.cpp should be changed from:

mco->rate = 1.6;

to

mco->rate = 1/(.884*Client::CalcPriceMod(tmp,true));

line 3842 of zone/client_packet.cpp should be changed from:

mpo->price = (item->Price*127/100)*mp->quantity;

to

mpo->price = (item->Price*(1/.884)*Client::CalcPriceMod(tmp,false))*mp->quantity;

line 3947 of zone/client_packet.cpp should be changed from:

price=(int)((item->Price*mp->quantity)*.884);

to

price=(int)((item->Price*mp->quantity)*.884*Client::CalcPriceMod(vendor,true)+0.5); // need to round, because client does it automatically when displaying price

line 4001 of zone/client_packet.cpp should be changed from:

inst2->SetPrice(item->Price*127/100);

to

inst2->SetPrice(item->Price*(1/.884)*Client::CalcPriceMod(vendor,false));

in zone/client_process.cpp, the following should be moved from 878 to 804:

Mob* merch = entity_list.GetMobByNpcTypeID(npcid);

line 831 of zone/client_process.cpp should be changed from:

inst->SetPrice(item->Price*127/100);

to

inst->SetPrice((item->Price*(1/.884)*Client::CalcPriceMod(merch,false)));

line 862 of zone/client_process.cpp should be changed from:

inst->SetPrice(item->Price*127/100);

to

inst->SetPrice((item->Price*(1/.884)*Client::CalcPriceMod(merch,false)));

[Aramid]

Originally Posted by cavedude

Moving to submission. To make it easier on KLS/Scorp, could you diff your changes?

CD, for those of us who used to be WinDoze users, can you tell us what the correct Syntax is to create a diff file?

Thanks

[So_1337]

Another great fix. Keep up the great work, Greg! =)

[Angelox]

Originally Posted by Aramid

CD, for those of us who used to be WinDoze users, can you tell us what the correct Syntax is to create a diff file?

Thanks

In Linux, diff is integrated in the os. You can make diffs/patches via command line. There are also some very nice graphical interfaces you can add, that help you see even better (kompare, xxdiff).
When I first started here at EqEmu, I couldn't for the best of me, get the source to compile under my windows box. So I took it to my Linux box where I had little trouble there - it was better this happened to me, because Linux Distros usually come "developer ready" and have all these neat tools like diff, kompare, compilers, etc. They are all just as available as my "dir" or "copy" command in windows.
I think I'm gonna try windows compile again with that new compiler package that's posted here, just for the challenge.
Anyways, you usually can google what you need for windows - I just googled "diff program for windows xp", and came up with a whole swarm of stuff. The diff toolshould be self explanatory on how you present it here.

[moydock]

Great fix man thanks, I've been hoping someone would fix factions, and I didn't even realize it was giving the incorrect gold when selling.

[Aramid]

Originally Posted by Angelox

In Linux, diff is integrated in the os. You can make diffs/patches via command line. .
I think I'm gonna try windows compile again with that new compiler package that's posted here, just for the challenge.
Anyways, you usually can google what you need for windows - I just googled "diff program for windows xp", and came up with a whole swarm of stuff. The diff toolshould be self explanatory on how you present it here.

I know about the diff command, was looking for a specific command line.. but that's ok.

Hey Angelox, try compiling the BOT CODE in Windows and let me know if it works for you. I can't get it to recognize that the BOTS are compiled in. Have everything set as AFGAIK in Preprocessor and files are all in place, but no go.

[erde]

I think "diff -Nur ..." is the right command

[Scorpious2k]

This will be in version 1113.

[ChaosSlayer]

i am looking at new sell prices after thsi patch and it seems to me than vendor now pays you way to much.

with only amiable faction and 100 cha i am geting back like 95% item price, while on most items 50% shoudl be best what you can get.

is it posible to change fixed 1.27 vendor modifier into an X variable and put into rules, so we can customly adjust how much extra vendor will charge/pay?

curent buy back prices way to high - you should only get to 95% buy back with Ally faction and 500 CHA

PS may as well include a rule on MAX % of item price vendor will ever pay regardless your faction