Bug Fix: Show pet buffs icons in pet window

[Derision]

After looking over this again, the call to SendPetBuffsToClient in Mob::BuffFadeByEffect is redundant, since BuffFadeByEffect calls BuffFadeBySlot, and the pet window buff packet is already sent in that routine.

So, after applying the patch, you can delete these lines:

spells.cpp, Line 2614:

void Mob::BuffFadeByEffect(int effectid, int skipslot)
{
        int i;

        for(i = 0; i < BUFF_COUNT; i++)
        {
                if(buffs[i].spellid == SPELL_UNKNOWN)
                        continue;
                if(IsEffectInSpell(buffs[i].spellid, effectid) && i != skipslot)
                        BuffFadeBySlot(i, false);
        }
        // Delete the following 3 lines as they are redundant.
        if(IsPet() && GetOwner() && GetOwner()->IsClient()) {    
                SendPetBuffsToClient();                                     
        }                                                                           
        //we tell BuffFadeBySlot not to recalc, so we can do it only once when were done
        CalcBonuses();
}

[So_1337]

Another great submission. If you keep this up, we're going to have a whole slew of functionality that wasn't there before just by connecting a few missing op_codes. Keep up the great work!

[KLS]

Nice, I'll get this all sorted out and in submission in a few days.

[Angelox]

Wow, thought i'd never see the buffs on pets again - Thanks again!

[joligario]

I remember on live not being able to click off beneficial spells from pet. So its all good. Good work.

[KLS]

Something I'm changing: not sending a pet buff update every client buff tic. I don't see the point really, also adding a pet buff update at connect finishing since without the buff tic update it wont show up on zoning without it.

Save roughly 2k/min per client connected this way which may not be a lot but if we keep adding things like it because they're "not a lot" they add up.

[trevius]

Thanks KLS! Every bit helps! Sounds like some really nice adjustments.