1126 and 1127 crashing

**trevius** · #1 08-17-2008, 01:35 AM

I am not sure if the problem is on my end or not, but I tried running version 1126 and 1127 and both cause my zones to crash when players try to form a group. I did add the new table in and it seems like the group does get added to the table for a minute, but the zone crashes at the same time.

Maybe I am still missing something, but I figured it was worth mentioning in case someone else sees similar problems.

**KLS** · #2 08-17-2008, 01:40 AM

It's fixed in 1128; which I'm not sure why it didn't get added to the nightly builds last night.

**trevius** · #3 08-17-2008, 01:45 AM

Thanks KLS! BTW, that raid work looks amazing. I mentioned to my server that raids were being looked into and they sounded really excited

**KLS** · #4 08-17-2008, 01:50 AM

SVN looks down atm which may explain it.

Groups.cpp
Group::Group(Mob* leader)
Remove the top two function calls to cleargroup and cleargroupleader

Also there's a somewhat rare crash in countdispellablebuffs where an invalid spell is checked against adding a IsValidSpell for the buff.

I don't have a diff unfortunately but the big one is the group constructor resetting groups to null -.-.

**trevius** · #5 08-17-2008, 04:22 AM

Quote:

Originally Posted by KLS

SVN looks down atm which may explain it.

Groups.cpp
Group::Group(Mob* leader)
Remove the top two function calls to cleargroup and cleargroupleader

Also there's a somewhat rare crash in countdispellablebuffs where an invalid spell is checked against adding a IsValidSpell for the buff.

I don't have a diff unfortunately but the big one is the group constructor resetting groups to null -.-.

Thanks again. NP on not having a diff. I will just wait until it is ready. I just wanted to make sure that if anyone else was seeing that problem that I mentioned it so they knew it wasn't something on their end.

I happened to find it while I was moving my database from Linux to my Windows PC temporarily so I could install raid drives on my Linux PC. First I went to 1127 and saw that there were a ton of crashes happening, so I went down to 1126 and they were still going on. So, I just figured it was a problem with my Windows config lol. I was busy trying to get the Linux PC rebuilt so I didn't put much thought into it. Finally, I ran into enough issues with getting raid working properly that I figured I better fix my windows server. Thought that I might as well try 1125 since I knew that one worked, and sure enough that resolved it lol. Glad it did too, cause it took some pressure off of my shoulders. They can play just fine on my Windows PC while I get the raid working at my own pace.

So_1337 · #6 08-17-2008, 09:32 AM

I didn't want to be a pest since it sounded like you had plenty of feedback from over at PEQ to work from, but groups were being disbanded any time that someone zoned as well. I'm guessing that's fixed in 1128?

You've done quite a few huge overhauls, and they're going to help in big ways. I've actually been surprised how many different things you've been touching on with each update, you're all over the place! And it's great stuff. Thanks again!

**cavedude** · #7 08-17-2008, 10:38 AM

I would recommend grabbing the source from CVS, it is at least 12 hours faster than the nightly builds.

Yep, players being disbanded when they zoned is also fixed in 1128, as that tied in with the zone crash.

So_1337 · #8 08-19-2008, 10:49 AM

I can get the source from CVS, too? Damn, wish I'd known! I'd only been using it for quests, the database, and for the PHP editor.

I'll see what I can track down, thanks for the tip =)

**cavedude** · #9 08-19-2008, 11:14 AM

Here's the link to the info page: http://sourceforge.net/cvs/?group_id=88515

So_1337 · #10 08-19-2008, 11:26 AM

Haha, yeah, downloading it now. Had just found it before I came back here and saw a new post. Guess I have to learn to compile myself if I want to go this route, though. I normally snag the binaries. I'm guessing that's the automated portion of things that KLS noted was down?

I can be patient, but I thank you very much for all the help anyhow =)

**trevius** · #11 08-20-2008, 04:36 PM

Quote:

Originally Posted by KLS

SVN looks down atm which may explain it.

Groups.cpp
Group::Group(Mob* leader)
Remove the top two function calls to cleargroup and cleargroupleader

Also there's a somewhat rare crash in countdispellablebuffs where an invalid spell is checked against adding a IsValidSpell for the buff.

I don't have a diff unfortunately but the big one is the group constructor resetting groups to null -.-.

Is SVN still down? Looks like the 1128 download is still MIA.

Angelox · #12 08-20-2008, 04:44 PM

Here's the 'Angelox' method;
go here
When you go into a directory, sort by date, newest up at the top. right click 'save as' on the files you see that are new.
Eventually, you'll have all the new files, copy them over to the most recent version EqEmU already posted.
Usually the changes are in /zone and /common - sometimes in /world.
You have to click on the file , tell you get to an option to save it.

**KLS** · #13 08-20-2008, 06:23 PM

It's still down I think there might also be a compile error when one of my commits clipped some of my early raid work. Can't really tell as.. it's down. If you can't compile yourself I'd suggest using an older version for now. CVS as pointed out should have 1128.

So_1337 · #14 08-22-2008, 01:52 PM

SVN makes me SAD.

**cavedude** · #15 08-22-2008, 03:12 PM

Here's 1128 from CVS, with the Windows binaries compiled in the Build directory:

http://projecteq.net/cavedude/EQEmuCVS-1128.zip

Anybody who diffs against the auto build source may have to fiddle with this a bit, as the two sets seem to differ a tiny bit in regards to spacing and line endings.