Combat Fixes

[James76]

I appreciate the positive responses as well as positive attitudes. I must apologize for my last message, I'm home sick with the flu and every little thing is bothering me, its strange how it all adds up to grumpiness and general discomfort. I still want to push out more changes, the two 'key' fixes (no pun intended) will be coming soon, I've pseudo-coded it in a list.. But I also have much bigger changes headed your way, though I haven't dug-in to tell if they're database issues or code bugs. My list is growing, and at some point I'm going to overwhelm the forum a little, which would make me sit on my hands in frustration some more. I have my mind bent on solving the pathing problem eventually, I have thought of several ways of doing that.

Again accept my apologies, no hard feelings, I'm sick and irritable ATM. The furthest I got was shutting down my linux server. I can't guarantee how much time I can dedicate, I may be starting training in January to be a Navy officer, just awaiting some more go-aheads..

[James76]

In case anybody is taking a serious interest in C++, I recommend a book for you, The C++ Programming Language written by Stroustrup himself. You can have a "look inside" by following this link. You can probably find a torrent of it. Another book worth having is The C++ Standard Template Library, aka STL, which is highly useful because of templates in C++, which is one of the facets most people skip or have trouble with when jumping into C++ from another language. Templates essentially allow type-less classes, functions, methods, and containers.. You can even apply algorithms to them with "magical" ease. But just remember, there is never any magic, everything is somewhere.

The problem I had when I started learning to program when I was young, was that I didn't have anyone to go to for help when I had a bug, so I had to solve everything on my own.. Given enough time, I could eventually solve any problem. But since I'm here, I'd be glad to answer anybody's questions so they could use me as a valuable resource if they're taking programming in school or are stuck on something. Not having help was a big pain in the butt, but I learned patience and perseverance in the process..

Also many books contained errors which made learning difficult... Many programming books I found have errors, as well as many calculus books... The latter is probably worse... lots of hand-wringing!

[trevius]

I was able to get your monk H2H code in, but I haven't been able to get any of your other stuff tested yet. Part of the problem is that I am making some adjustments to how ProcChance and chancetohit work for certain things. So, some of your submission overlaps with what I am working on. Though, it looks like your stuff for ProcChance is just for formatting it correctly and not actually effecting the calculation equations. But, I like to do 1 thing at a time to reduce possible issues.

I am still trying to figure out the best way to get this stuff chanced in the source. Unless all of the code that was missing on the diff was already added to the SVN, It looks like even the diff that erde posted still doesn't have alot of the code that James76 posted. It is a definite starting place, though.

I hate to ask it, but;

James76, if you get a chance, is there anyway you could download the latest SVN and add in your changes to it and post a diff for them? You should be able to use something like examdiff or whatever, but I imagine with your coding experience, you probably know very well about how to do a diff, lol :P

Unless one of the other people with SVN access wants to add in what you have already submitted, then they can probably save you from having to do that diff. But, if it is going to be me adding it, I will need that diff or it will take me too much time to be worth it. I have a house, wife, kid, 2 forums to handle, a pretty popular emu server, and of course my own code changes and content to work on, so time is important to me. Not that I am any busier than most of the dev/mod team, because I know we all have stuff to keep us busy lol.

If anyone else from the team wants to try to get these added, feel free! It will stop any further time from being used up on this code change. Hopefully once we get this in, any further updates from James76 will move much quicker and smoother. Proper submission process will help that alot.

[erde]

I added all changes from that post. Can you tell me what i have missed?

[trevius]

Oops, sorry! I must have not copied and paste the whole thing into the post for some reason. I edited my other post so it has the full diff in it.

[erde]

No problem Today i have checked the diff and it seems everything is in.
But i dont have enough time at the moment and i made it in hurry. So i could have overlooked some parts