New Rule: Flagging Hostile NPCs

[leslamarch]

I really like the idea of this, I found a problem with it and really didnt look to much further. With this code added in pet classes will no longer be able to raise a pet, The spell goes off just as it should but the pet just never appears, and the regent is also consumed. I Ran out of time to do any further testing on this, sorry :(

*edit* this patch maybe fine for the stock source, I do have some custom code. The only thing i tested was pets work with the patch commented out, but with this active again pets no longer work.

[Shendare]

That's... odd... do pets somehow make use of the lastName field?

[ChaosSlayerZ]

technicly pets should not be using the "hosile" tag. Even if its an npc's pet, the npc should be taged "hostile" , not pet. Pet is just pet

[Shendare]

Right, and pets generally con as indifferent anyway, which would prevent them from ever getting to the tagging portion, which only activates for Glares Threateningly or Ready to Attack.

[Kobaz]

Testing with an otherwise stock server, this change does indeed stop pets being raised. It's a shame, as it's the kind of thing that would make the game more friendly for very young players.

[Shendare]

Roger that.

I'll have to take a deeper look to figure out what could possibly be going wrong with such a simple little piece of code.

[Shendare]

Okay, apparently the problem was caused by a call to GetReverseFactionCon() for a non-player entity.

Fixed with the following code change:

File: mob.cpp, Line 817 - mob::FillSpawnStruct()

  if (ForWho && ForWho->IsClient() && RuleB(World, FlagHostileNPCs))
  {
    switch (ForWho->CastToClient()->GetReverseFactionCon(this))
    {
      case FACTION_THREATENLY:
      case FACTION_SCOWLS:
        memcpy_s(ns->spawn.lastName, sizeof(ns->spawn.lastName), "Hostile", 8);
        break;
    }
  }

On an unrelated note, I found that if you have a pet, you can aggro hostile NPCs even with the GM flag on. LOL.

It's hard to tell whether the pet's aggroing the NPC or the NPC is aggroing on the pet.