Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Server Code Submissions

 
 
Thread Tools Display Modes
Prev Previous Post   Next Post Next
  #2  
Old 05-10-2010, 10:33 PM
trevius's Avatar
trevius
Developer
 
Join Date: Aug 2006
Location: USA
Posts: 5,946
Default

Not a big issue, but when you submit changes with diffs, it is good to correct spelling errors so they get fixed:

Code:
//is there a garunteed hit disc in place?

Code:
//is there a guaranteed hit disc in place?

Also, we have been removing names from the source comments, since there isn't really a need to have them there anymore. If something has been changed and we want to know who did it, that is what the SVN diffs are for

Again, that isn't a big deal, but just mentioning it. I believe there has been a coding standards list in the works that just hasn't been posted yet.

Thanks for the submissions. I checked the others you posted and they looked pretty good. I will leave this one up to KLS to add, as I hate messing with core systems like that when I don't have to :P

If you keep up like this, we may need to see if giving you SVN access is an option :P
__________________
Trevazar/Trevius Owner of: Storm Haven
Everquest Emulator FAQ (Frequently Asked Questions) - Read It!
Reply With Quote
 


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 02:21 PM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3