Quote:
Originally Posted by trevius
I am still testing most of the effects you have submitted. I haven't been able to test this one or the skill attack one yet due to some crash issues in the latest source updates. I wanted to mention here that I was also getting some crashes that seemed to be caused by the heal code here. I think they were just related to a potential null pointer that is easily fixed by doing something like this:
Code:
@@ -3143,7 +3139,10 @@
//healing spell...
//healing aggro would go here; removed for now
if(caster)
+ {
+ if(caster->GetTarget())
+ effect_value = GetHealRate(effect_value, caster->GetTarget());
effect_value = caster->GetActSpellHealing(spell_id, effect_value);
+ }
HealDamage(effect_value, caster);
}
|
Yeah, unfortunately there's no way to get a caster out of zone, so this is the best solution for now; same issues I ran into with Mythic, Timesfive, etc, when doing the spelldamage/healing code. It may be worth mentioning that it's probably better to add GetHealRate into GetActSpellHealing instead of that function. Also, it may be worth looking into making an NPC::GetActSpellHealing, for those times when NPCs calculate differently.
Threaded Mode
