World Crashes with latest source

[Uleat]

https://github.com/EQEmu/Server/blob...rver.cpp#L1409

The 'pack' destructor is called with this action: https://github.com/EQEmu/Server/blob...vertalk.h#L206


But, the pBuffer was referenced here: https://github.com/EQEmu/Server/blob...rver.cpp#L1384

And is being called through 's' after the pBuffer allocation is released (here: https://github.com/EQEmu/Server/blob...rver.cpp#L1412)

[epilz]

Thanks Uleat. Will test today.

[joligario]

Pushed update to address this.

[Uleat]

Thanks J!

My head is still wonky and I don't touch the code when it's like this..for obvious reasons...

[epilz]

Server is updated with new source, been running about 6 hours so far, no errors yet

[epilz]

Another crash just happened.

[04-21-2015 :: 17:52:44] [Crash] EXCEPTION_BREAKPOINT
[04-21-2015 :: 17:52:44] [Crash] SymInit: Symbol-SearchPath: '.;V:\EQ\EQEmuServer;V:\EQ\EQEmuServer;C:\Windows;C:\Windows\system32;SRV*C:\websymbols*http://msdl.microsoft.com/download/symbols;', symOptions: 530, UserName: 'Administrator' 
[04-21-2015 :: 17:52:44] [Crash] OS-Version: 6.2.9200 () 0x110-0x3 
[04-21-2015 :: 17:52:44] [Crash] V:\EQ\EQEmuServer\zone.exe:zone.exe (00F90000), size: 31465472 (result: 0), SymType: 'PDB', PDB: 'V:\EQ\EQEmuServer\zone.exe' 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\ntdll.dll:ntdll.dll (772E0000), size: 1499136 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\ntdll.dll', fileVersion: 6.3.9600.17736 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\KERNEL32.DLL:KERNEL32.DLL (76C60000), size: 1310720 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\KERNEL32.DLL', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\KERNELBASE.dll:KERNELBASE.dll (75350000), size: 880640 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\KERNELBASE.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\system32\apphelp.dll:apphelp.dll (74050000), size: 655360 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\apphelp.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\AppPatch\AcLayers.DLL:AcLayers.DLL (6F880000), size: 2584576 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\AppPatch\AcLayers.DLL', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\msvcrt.dll:msvcrt.dll (76DA0000), size: 798720 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\msvcrt.dll', fileVersion: 7.0.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\USER32.dll:USER32.dll (75430000), size: 1388544 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\USER32.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\GDI32.dll:GDI32.dll (76F90000), size: 1105920 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\GDI32.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\SHELL32.dll:SHELL32.dll (75960000), size: 19578880 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\SHELL32.dll', fileVersion: 6.3.9600.17680 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\SHLWAPI.dll:SHLWAPI.dll (74EB0000), size: 282624 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\SHLWAPI.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\OLEAUT32.dll:OLEAUT32.dll (758B0000), size: 610304 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\OLEAUT32.dll', fileVersion: 6.3.9600.17560 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\MPR.dll:MPR.dll (74670000), size: 90112 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\MPR.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\SETUPAPI.dll:SETUPAPI.dll (75130000), size: 1773568 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\SETUPAPI.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\sfc.dll:sfc.dll (74660000), size: 12288 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\sfc.dll', fileVersion: 6.3.9600.16384 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\WINSPOOL.DRV:WINSPOOL.DRV (74830000), size: 413696 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\WINSPOOL.DRV', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\RPCRT4.dll:RPCRT4.dll (755E0000), size: 761856 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\RPCRT4.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\combase.dll:combase.dll (74B10000), size: 1560576 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\combase.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\CFGMGR32.dll:CFGMGR32.dll (74D40000), size: 245760 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\CFGMGR32.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\SspiCli.dll:SspiCli.dll (74AE0000), size: 122880 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\SspiCli.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\sfc_os.DLL:sfc_os.DLL (744D0000), size: 61440 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\sfc_os.DLL', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\CRYPTBASE.dll:CRYPTBASE.dll (74AD0000), size: 40960 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\CRYPTBASE.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\sechost.dll:sechost.dll (75590000), size: 266240 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\sechost.dll', fileVersion: 6.3.9600.17734 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\bcryptPrimitives.dll:bcryptPrimitives.dll (74A70000), size: 344064 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\bcryptPrimitives.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\system32\IMM32.DLL:IMM32.DLL (77160000), size: 159744 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\IMM32.DLL', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\MSCTF.dll:MSCTF.dll (76E70000), size: 1122304 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\MSCTF.dll', fileVersion: 6.3.9600.17706 
[04-21-2015 :: 17:52:44] [Crash] C:\Perl\bin\perl512.dll:perl512.dll (28000000), size: 1273856 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\bin\perl512.dll', fileVersion: 5.12.3.1204 
[04-21-2015 :: 17:52:44] [Crash] V:\EQ\EQEmuServer\lua51.dll:lua51.dll (73FF0000), size: 356352 (result: 0), SymType: '-exported-', PDB: 'V:\EQ\EQEmuServer\lua51.dll' 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\WS2_32.dll:WS2_32.dll (76C10000), size: 327680 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\WS2_32.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\VERSION.dll:VERSION.dll (746A0000), size: 32768 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\VERSION.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\ADVAPI32.dll:ADVAPI32.dll (77190000), size: 507904 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\ADVAPI32.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_5.82.9600.17415_none_7c5769eaaa0aa358\COMCTL32.dll:COMCTL32.dll (74750000), size: 561152 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_5.82.9600.17415_none_7c5769eaaa0aa358\COMCTL32.dll', fileVersion: 5.82.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\MSVCR110.dll:MSVCR110.dll (73210000), size: 876544 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\MSVCR110.dll', fileVersion: 11.0.51106.1 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\NSI.dll:NSI.dll (74C90000), size: 28672 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\NSI.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\system32\napinsp.dll:napinsp.dll (74A50000), size: 69632 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\napinsp.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\system32\NLAapi.dll:NLAapi.dll (74A30000), size: 81920 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\NLAapi.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\System32\mswsock.dll:mswsock.dll (749E0000), size: 307200 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\mswsock.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\DNSAPI.dll:DNSAPI.dll (74940000), size: 516096 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\DNSAPI.dll', fileVersion: 6.3.9600.17481 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\System32\winrnr.dll:winrnr.dll (74820000), size: 40960 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\winrnr.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\System32\rasadhlp.dll:rasadhlp.dll (74690000), size: 32768 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\rasadhlp.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Perl\lib\auto\Cwd\Cwd.dll:Cwd.dll (10000000), size: 20480 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\lib\auto\Cwd\Cwd.dll' 
[04-21-2015 :: 17:52:44] [Crash] C:\Perl\site\lib\auto\DBI\DBI.dll:DBI.dll (04D10000), size: 98304 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\site\lib\auto\DBI\DBI.dll' 
[04-21-2015 :: 17:52:44] [Crash] C:\Perl\lib\auto\List\Util\Util.dll:Util.dll (04D30000), size: 28672 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\lib\auto\List\Util\Util.dll' 
[04-21-2015 :: 17:52:44] [Crash] C:\Perl\lib\auto\Filter\Util\Call\Call.dll:Call.dll (04D40000), size: 20480 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\lib\auto\Filter\Util\Call\Call.dll' 
[04-21-2015 :: 17:52:44] [Crash] C:\Perl\lib\auto\IO\IO.dll:IO.dll (04D50000), size: 24576 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\lib\auto\IO\IO.dll' 
[04-21-2015 :: 17:52:44] [Crash] C:\Perl\site\lib\auto\DBD\mysql\mysql.dll:mysql.dll (04D60000), size: 86016 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\site\lib\auto\DBD\mysql\mysql.dll' 
[04-21-2015 :: 17:52:44] [Crash] C:\Perl\site\lib\auto\DBD\mysql\LIBMYSQL.dll:LIBMYSQL.dll (0D880000), size: 1519616 (result: 0), SymType: '-exported-', PDB: 'C:\Perl\site\lib\auto\DBD\mysql\LIBMYSQL.dll' 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\WSOCK32.dll:WSOCK32.dll (744C0000), size: 32768 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\WSOCK32.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\System32\fwpuclnt.dll:fwpuclnt.dll (744E0000), size: 286720 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\System32\fwpuclnt.dll', fileVersion: 6.3.9600.17485 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\system32\uxtheme.dll:uxtheme.dll (74550000), size: 970752 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\uxtheme.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\system32\dwmapi.dll:dwmapi.dll (74530000), size: 106496 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\dwmapi.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\system32\ole32.dll:ole32.dll (74D80000), size: 1212416 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\system32\ole32.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\kernel.appcore.dll:kernel.appcore.dll (74480000), size: 36864 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\kernel.appcore.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] C:\Windows\SYSTEM32\dbghelp.dll:dbghelp.dll (6F730000), size: 1314816 (result: 0), SymType: '-exported-', PDB: 'C:\Windows\SYSTEM32\dbghelp.dll', fileVersion: 6.3.9600.17415 
[04-21-2015 :: 17:52:44] [Crash] g:\bs\connector-c-vs2008-32bit\src\mysql-connector-c-6.0.2\mysys\my_thr_init.c (510): my_sigabrt_handler 
[04-21-2015 :: 17:52:44] [Crash] f:\dd\vctools\crt\crtw32\misc\winsig.c (587): raise 
[04-21-2015 :: 17:52:44] [Crash] f:\dd\vctools\crt\crtw32\misc\dbgrpt.c (401): __crtMessageWindowW 
[04-21-2015 :: 17:52:44] [Crash] f:\dd\vctools\crt\crtw32\misc\dbgrptt.c (672): _VCrtDbgReportW 
[04-21-2015 :: 17:52:44] [Crash] f:\dd\vctools\crt\crtw32\misc\dbgrpt.c (262): _CrtDbgReportWV 
[04-21-2015 :: 17:52:44] [Crash] f:\dd\vctools\crt\crtw32\misc\dbgrpt.c (279): _CrtDbgReportW 
[04-21-2015 :: 17:52:44] [Crash] f:\dd\vctools\crt\crtw32\convert\isctype.c (56): _chvalidator 
[04-21-2015 :: 17:52:44] [Crash] f:\dd\vctools\crt\crtw32\convert\_ctype.c (70): isalpha 
[04-21-2015 :: 17:52:44] [Crash] v:\eq\source\zone\client.cpp (7503): Client::GarbleMessage 
[04-21-2015 :: 17:52:44] [Crash] v:\eq\source\zone\client.cpp (1172): Client::ChannelMessageSend 
[04-21-2015 :: 17:52:44] [Crash] v:\eq\source\zone\client.cpp (1113): Client::ChannelMessageSend 
[04-21-2015 :: 17:52:44] [Crash] v:\eq\source\zone\entity.cpp (1821): EntityList::ChannelMessageFromWorld 
[04-21-2015 :: 17:52:44] [Crash] v:\eq\source\zone\worldserver.cpp (173): WorldServer::Process 
[04-21-2015 :: 17:52:44] [Crash] v:\eq\source\zone\net.cpp (349): main 
[04-21-2015 :: 17:52:44] [Crash] f:\dd\vctools\crt\crtw32\startup\crt0.c (255): __tmainCRTStartup 
[04-21-2015 :: 17:52:44] [Crash] f:\dd\vctools\crt\crtw32\startup\crt0.c (165): mainCRTStartup 
[04-21-2015 :: 17:52:44] [Crash] ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 76C77C04) 
[04-21-2015 :: 17:52:44] [Crash] 76C77C04 (KERNEL32): (filename not available): BaseThreadInitThunk 
[04-21-2015 :: 17:52:44] [Crash] ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 7733AD1F) 
[04-21-2015 :: 17:52:44] [Crash] 7733AD1F (ntdll): (filename not available): RtlInitializeExceptionChain 
[04-21-2015 :: 17:52:44] [Crash] ERROR: SymGetLineFromAddr64, GetLastError: 487 (Address: 7733ACEA) 
[04-21-2015 :: 17:52:44] [Crash] 7733ACEA (ntdll): (filename not available): RtlInitializeExceptionChain

And here is windows error

[joligario]

Completely different issue, btw.

EDIT: Do you know what client was drunk and what they were /saying?

EDIT2: I guess it could be language training too.

[Uleat]

Any chance that you could grab the message that is being Garbled?

I'm willing to say that it could be part of the 'delimiter' code..but, I'd like to see if your trying to assert on a character that is
out of range first (like a character value above 127.)

[joligario]

Uleat, I was also curious if it could be but I couldn't break the delimiter code. You may be right about the non-standard ASCII values, though.

[Uleat]

I found a similar issue regarding an 'isdigit' call:
https://connect.microsoft.com/Visual...debug-compiles

In particular:
"The assert ensures EOF (-1) and the values representable by an unsigned char (0 to 0xFF) are the only values allowed as input to this function. To ensure the implicit cast to int results in a valid value, be sure to cast char values to unsigned char."


I'll push a fix for this..but, we may need to keep an eye on future crashes - if it is relevant.


EDIT: Ok, pushed a fix for this particular case. If you run across any more, or if this causes issues, please post back.

[epilz]

Will keep this thread updated for future crashes. Also, I did see a garbled message right before the crash this morning. Character was talking to me in /say and this text showed all boxes [] <----like this, but about 20 of them

[epilz]

Hey Uleat, noticed the changelog, and updated to that new source, no errors so far

[epilz]

So far so good. No more crashes.

[Uleat]

Have you had any more occurrences (or reports of) text coming in with the undisplayable characters (boxes)?

(Thanks for the update, btw )

[epilz]

Yes, I witnessed it once yesterday, but it did not crash zone.exe like it had in the past.