Update: I checked out the source code and I don't think the bug is with OP_GMZoneRequest, I think it's actually in the handling of OP_GMZoneRequest2 (opcode 0x023c)
This is the block of code in client_process.cpp that handles that:
Quote:
case OP_GMZoneRequest2: {
int32 zonereq = (int32)*app->pBuffer;
if(zonereq == zone->GetZoneID())
this->MovePC(zonereq, zone->safe_x(), zone->safe_y(), zone->safe_z(), 0, false);
else
this->MovePC(zonereq, -1, -1, -1, 0, false);
break;
}
|
That first line:
Quote:
|
int32 zonereq = (int32)*app->pBuffer;
|
just doesn't look right. I think it's evaluating *app->pBuffer to be only a 1-byte integer (pbuffer is type uchar after all), THEN casting that to int32 which doesn't do us much good. Before LDoN/GoD, we could get away with it because there were less than 256 zones.
Perhaps it should be changed to:
Quote:
|
int32 zonereq = (int32) (app->pBuffer[0] + (app->pBuffer[1]*256));
|
I don't (yet) have a compiler or I'd test this out myself.
Course, even that suggested line is a bit short-sighted... I mean, what are we gonna do when there's more than 65,536 zones in the game? :P
Threaded Mode
