Power Source Slot - Page 2

**cavedude** · #16 06-10-2009, 02:27 PM

I know! But, all I want to know is who's on first?!?!?!

**gaeorn** · #17 06-10-2009, 02:32 PM

Thats what I was asking...

**trevius** · #18 06-11-2009, 05:46 PM

I think I got most of the code for the new slot arrangements in last night, but I still need to finish it off before putting anything on the SVN. The slot conversion stuff is a little tricky, so I am trying to get everything working without messing up one of the conversion pieces. Some pieces of code look at the actual slot that the item is allowed to be used for and some are just looking to see what slot the item is currently in. I must have done one of the conversions wrong somewhere, because currently I the items I set to be Power Source equipable are now only showing up as Ammo slot usable.

I just need to go through the changes I am working on and make sure I have each piece set to do the appropriate handling of the different slot settings. I think I have most of it set correctly, so it should be just that I am just doing a conversion somewhere that doesn't need one and it is throwing something off.

My main concern is that I get everything right, because messing up could potentially cause some issues. Hopefully it wouldn't mean any problems with normal slots, since it should mostly only be related to the Power Source or new Slot 22 handling. Though, since in Titanium slot 22 is the first open inventory slot, I am trying to make sure I don't cause problems with that. If something is wrong with the code for it, it shouldn't be hard to correct it quickly. I just don't want any items to be deleted by mistake, but I really doubt that will happen. That is really the only thing that scares me about the changes.

As soon as I get it done and tested on my test server, I will put it on the SVN as well as on Storm Haven. So, if there are going to be any issues with it, I should know within the first day so it can be corrected quickly. Basically, I am just giving a warning about trying it the first day that it goes onto the SVN. Or, at least to do a DB backup before putting it on the server. I will try to make sure all possible issues are tested, but one person testing vs a whole server testing in actual production are 2 different things :P

**trevius** · #19 06-12-2009, 06:16 AM

Ok, I think I have everything working about as good as it is going to get. It seems to be pretty good. The only odd thing I noticed is that if I #nukeitem on an item in my Power Source slot, I sometimes get a bunch of client failed to move item messages. The item still gets removed and I don't see any other side effects. I tested in both SoF and in Titanium and everything else was very smooth. In SoF, the Power Source slot now gives stats if stats are set on it and the stats show up both client and server-side. I believe that Worn and Focus Effects should also work for the Power Source slot as well now. Another interesting thing I noticed is that if you equip a Power Source while running SoF and then log off and back in with Titanium on the same character, the Power Source will automatically move into your first available normal inventory (bag) slot.

So, the only thing left to do is figure out exactly how the Power Source works on Live and code that in at some point. Given that our code for Charms is able to work on any slot, it might even be possible to use it for the Power Source slot to make it simulate what it does on Live. If that is the case, then Power Source should be all done and the rest would just be adjusting the database or making scripts to give the Power Sources the features that they are supposed to have. There is no rush on this as for the time being (and probably for a long time to come), the only use for the Power Source slot will be for custom servers. But, I think it is a nice option to have either way. It could definitely make for some nice rewards considering that you could have extra focus effects, stats, or even a clicky on it that saves having to use another slot to have a readily available clicky at all times.

It has been updated to the SVN and I am going to get it going on SH as well. I will probably add Power Source slot to a few existing items that we have set to be able to use the Ammo slot, so it can be used in both. This way, maybe some people will actually get this tested and let me know if there are any problems.

**trevius** · #20 06-13-2009, 04:50 AM

Just found the first bug with the new Power Source slot code. Somehow, I just zoned and got 5 copies of the item from my Power Source slot to show up on my cursor. They are all lore as well. Not really sure what would have caused that. I will watch out for it to happen again and see if I can figure out what might cause it. Not really sure atm.

EDIT: OK, I am able to reproduce this now. Not sure why I wasn't seeing this issue last night when I was messing with this, because I zoned plenty of times. It seems that for some reason, the item shows up in the inventory table as being in slot 9999 properly, but it shows it as having 255 charges. It should only show 1 charge there, so something must be going wrong. It may be that this issue is caused after logging in the character with a Titanium client after having already placed the items in the Power Source slot on an SoF client. Then, after logging back off with the Titanium client, you log back in with the SoF client and zone and the problem happens. After doing that is when I started to notice this issue and before I was having no trouble with it.

Just did a bit more testing and used #nukeitem on the item I have in Power Source again and it nuked it ok, but gave a bunch of the "MOVE ITEM CHARGE FAILED IN CLIENT APPLICATION" messages. I was seeing that before as well when testing. So, maybe it is just that the item is getting set to 255 charges when being moved to the Power Source Slot for some reason. Shouldn't be too hard to figure out why that is and fix it I hope.

**trevius** · #21 06-13-2009, 08:20 AM

Ok, I think I got that issue fixed. I am not 100% sure yet, but I am unable to reproduce the problem anymore and it is no longer giving me the failed to move item messages multiple times when I delete an item that is currently in the Power Source slot.